fix(slots): consume eagerly rendered slot after one use #8929
Conversation
🦋 Changeset detectedLatest commit: 4dcc09c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
lilnasy
changed the title
github-actions
bot
added
the
pr: docs
.changeset/plenty-spiders-act.md
Outdated
| 'astro': patch | ||
| --- | ||
|
|
||
| Fixes an issue where a slot rendered multiple times resulted in the same output each time. |
There was a problem hiding this comment.
| Fixes an issue where a slot rendered multiple times resulted in the same output each time. | |
| Fixes an issue where rendering multiple slots resulted in the same output each time. |
super-nit: "a slot" rendered multiple times makes me think it's the same one slot, so the output should be the same! Would this be a correct description? (non-blocking, though)
There was a problem hiding this comment.
It is the same one slot.
There was a problem hiding this comment.
Now that you bring it up though, I think there is room for clarification. Before this PR, the first render was reused when users tried to manually render the same slot multiple times.
There was a problem hiding this comment.
OK, then maybe something like.... (wordy, but trying to see if this is the right idea)
Fixes an issue where a slot rendered multiple times incorrectly used the same initial rendering for each instance
* render slots lazily * add test * add changeset * refactor * reword changeset
Changes
Testing
Added a case to an existing fixture.
Docs
Does not affect usage.