-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] test config-reference formatting for sidebar #9052
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don’t think this will do what you want!
(Speed reviewed in case Ema’s approval made you merge this 😅) I’m pretty sure our logic in docs only distinguishes between Breaking for lunch, but we can take a look at a solution when I’m back. (FWIW the current version is potentially OK I think as it matches e.g. how we handle the |
Ah, yes, that makes sense. In that case, we probably also need to move the whole |
Yes, but I'm still not sure how to make the i18n options not show up in the sidebar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @sarah11918! Glad we’re no longer JSBlocked 🚀
Thanks for your help with this, @delucis ! This is now |
Co-authored-by: Chris Swithinbank <357379+delucis@users.noreply.github.com> Co-authored-by: Emanuele Stoppa <602478+ematipico@users.noreply.github.com> Co-authored-by: Elian <15145918+ElianCodes@users.noreply.github.com>
Changes
Changes
Prefetch
andi18n
intoheading
s to see if I can get the docs sidebar nested properlyTesting
This is a test! The automated PR for docs will let me test the output
Docs
Just docs!