Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow same-page navigations on form posts #9055

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Allow same-page navigations on form posts #9055

merged 2 commits into from
Nov 10, 2023

Conversation

matthewp
Copy link
Contributor

Changes

  • Normally when the user navigates to the same page we do not trigger a fetch + navigation, instead we just navigate to the hash (if there is one).
  • This should not be the case for form posts, which have side-effects that need to occur.
  • This also makes it possible to omit the action.

Testing

  • New test added

Docs

N/A, bug fix

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8c71d7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 10, 2023
natemoo-re
natemoo-re reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

packages/astro/src/transitions/router.ts Show resolved Hide resolved
@matthewp matthewp merged commit f105b10 into main Nov 10, 2023
13 checks passed
@matthewp matthewp deleted the form-no-action branch November 10, 2023 16:23
@matthewp matthewp mentioned this pull request Nov 10, 2023
Closed
1 task
natemoo-re pushed a commit that referenced this pull request Nov 22, 2023
@matthewp @natemoo-re
Allow same-page navigations on form posts (#9055)
17e9237 
* Allow same-page navigations on form posts

* Add another comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewp @natemoo-re