Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendored Vite importMeta.d.ts #9149

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Remove vendored Vite importMeta.d.ts #9149

merged 2 commits into from
Nov 22, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 21, 2023

Changes

Revert of #4499, using Vite 5's vite/types/import-meta.d.ts export. See vitejs/vite#14615

Testing

Tested manually with a repro project.

Docs

n/a. internal refactor. should not have any visible changes.

Copy link

changeset-bot bot commented Nov 21, 2023

🦋 Changeset detected

Latest commit: 09413dd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Nov 21, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is incredibly goofy that this is required. LGTM!

@bluwy bluwy merged commit 0fe3a7e into next Nov 22, 2023
13 checks passed
@bluwy bluwy deleted the plt-395-vite-import-meta branch November 22, 2023 03:17
@astrobot-houston astrobot-houston mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants