Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated matchNotFound options #9212

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

alexanderniebuhr
Copy link
Member

Changes

Testing

  • existing tests

Docs

  • no doc changes

Copy link

changeset-bot bot commented Nov 28, 2023

🦋 Changeset detected

Latest commit: dd64b44

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Nov 28, 2023
@alexanderniebuhr alexanderniebuhr changed the title Enter pre mode for Astro 4 beta remove deprecated matchNotFound options Nov 28, 2023
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, plus what @jacobthesheep suggested!

alexanderniebuhr and others added 3 commits November 29, 2023 08:06
Co-authored-by:  Matthew Phillips <matthew@skypack.dev>
Co-authored-by:  Matthew Phillips <matthew@skypack.dev>
@alexanderniebuhr alexanderniebuhr merged commit c0383ea into next Nov 29, 2023
13 checks passed
@alexanderniebuhr alexanderniebuhr deleted the nbhr/remove-matchnotfound branch November 29, 2023 07:23
This was referenced Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants