Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed positioning on x-ray when inside of fixed containers #9254

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Nov 30, 2023

Changes

  • When an island is inside of a fixed container, it should not use scrollY to position itself, as it will never change.
ExampleDocsScroll.mp4

Testing

  • Tested via the docs site (see video above)

Docs

N/A, bug fix

Copy link

changeset-bot bot commented Nov 30, 2023

🦋 Changeset detected

Latest commit: f15a92f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthewp
Copy link
Contributor Author

!preview xray-position

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Nov 30, 2023
Copy link
Contributor

github-actions bot commented Nov 30, 2023

⚖️ Bundle Size Check

Latest commit: f15a92f

File Old Size New Size Change
dev-overlay/plugins/utils/highlight 914 B 1005 B + 91 B
dev-overlay/plugins/xray 3.61 KB 3.76 KB + 154 B

@matthewp matthewp marked this pull request as ready for review November 30, 2023 20:17
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Few comments but you're clearly already thinking about them.

@matthewp matthewp merged commit b750a16 into main Nov 30, 2023
14 checks passed
@matthewp matthewp deleted the overlay-scroll-stuff branch November 30, 2023 22:04
This was referenced Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants