Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vercel): handle dots in source path for redirects #9289

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Dec 4, 2023

Changes

Testing

Added a test case

Docs

Does not affect behavior

Copy link

changeset-bot bot commented Dec 4, 2023

🦋 Changeset detected

Latest commit: ad2ba9a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pr: docs A PR that includes documentation for review labels Dec 4, 2023
@lilnasy lilnasy changed the title fix(vercel): handle dots in source path fix(vercel): handle dots in source path for redirects Dec 4, 2023
@lilnasy lilnasy marked this pull request as draft December 6, 2023 13:14
@lilnasy lilnasy force-pushed the fix/9260 branch 2 times, most recently from 011cff3 to f968eaa Compare December 8, 2023 16:35
@lilnasy lilnasy marked this pull request as ready for review December 8, 2023 16:37
Comment on lines -35 to 40
.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
.replace(/[*+?^${}()|[\]\\]/g, '\\$&');
})
.join('');
})
.join('');
.join('/');
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

image

After:

image

@lilnasy lilnasy merged commit 8aeb0b5 into withastro:main Dec 11, 2023
13 checks passed
@lilnasy lilnasy deleted the fix/9260 branch December 11, 2023 22:20
@astrobot-houston astrobot-houston mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vercel adapter redirects generate incorrect routes
4 participants