Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update netlify import #9461

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Dec 18, 2023

Changes

Closes #9459. With the new version of the Astro adapter, @astrojs/netlify is the recommended import.

Testing

Didn't test manually, but expecting it to still work given the change.

Docs

don't think we need docs changes for this.

Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: 605c97c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Dec 18, 2023
@jacobdalamb
Copy link
Contributor

jacobdalamb commented Dec 18, 2023

Can you update the example page too? And doc changes are needed.

@Skn0tt
Copy link
Contributor Author

Skn0tt commented Dec 18, 2023

Sure! Could you link me to the example page you're referring to?

@Skn0tt
Copy link
Contributor Author

Skn0tt commented Dec 18, 2023

I believe the docs will be updated by withastro/docs#5821.

@ematipico
Copy link
Member

Sure! Could you link me to the example page you're referring to?

I don't think we have examples with netlify in the examples/ folder. I think we're good this PR

@jacobdalamb
Copy link
Contributor

Sure! Could you link me to the example page you're referring to?

I don't think we have examples with netlify in the examples/ folder. I think we're good this PR

Sorry, I meant the Nelifty README.md

@ematipico
Copy link
Member

Sure! Could you link me to the example page you're referring to?

I don't think we have examples with netlify in the examples/ folder. I think we're good this PR

Sorry, I meant the Nelifty README.md

We moved the adapter in another repository

@ematipico ematipico merged commit 429be8c into withastro:main Dec 18, 2023
14 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[astrojs/netlify] generated adapter config should use @astrojs/netlify import
3 participants