Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent printing defineVars() into an inline style #1001

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: prevent printing defineVars() into an inline style #1001

wants to merge 3 commits into from
+14 −19

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Apr 12, 2024 •
edited
Loading

Changes

Testing

  • Added go test

Docs

  • Does not affect usage.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2024

⚠️ No Changeset found

Latest commit: c966a1c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

matthewp
matthewp reviewed Apr 12, 2024
View reviewed changes
package.json
@@ -7,7 +7,7 @@
"url": "https://github.com/withastro/compiler.git"
},
"scripts": {
"build": "make wasm",
"build": "CGO_ENABLED=0 GOOS=js GOARCH=wasm go build \"-ldflags=-s -w\" -trimpath -o ./packages/compiler/wasm/astro.wasm ./cmd/astro-wasm/astro-wasm.go",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this about?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that it isn't necessary to install make to contribute to the project, just pnpm and go.

@lilnasy lilnasy changed the title fix: prevent printing defineVars() into an inline script fix: prevent printing defineVars() into an inline style Apr 12, 2024
@jacobdalamb
Copy link

Can this be merged in the next release please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp left review comments

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

define:vars not working with is:inline directive in <style> tags
4 participants
@lilnasy @jacobdalamb @matthewp @ematipico