Handle nested expressions edge case #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 071b783 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
natemoo-re
changed the title
natemoo-re
added a commit
that referenced
this pull request
Jul 11, 2022
This reverts commit 62d2a8e.
Merged
natemoo-re
added a commit
that referenced
this pull request
Jul 11, 2022
Merged
natemoo-re
added a commit
that referenced
this pull request
Jul 20, 2022
* fix: handle nested expressions edge case * chore: explain how we use trackPreviousTokens Co-authored-by: Nate Moore <nate@astro.build>
natemoo-re
added a commit
that referenced
this pull request
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
StartTagTokenandEndTagTokenwould reset these heuristicsStartTagTokenandEndTagTokenthat determines if we're inside elements ({===StartExpressionToken) or outside of them ({===TextToken)Testing
Multiple test cases added
Docs
Bug fix only