feat: lower case hash #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 369fb4b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
force-pushed
the
feat/lower-case-hash
branch
5 times, most recently
from
831d055 to
8e1d79e
Compare
ematipico
force-pushed
the
feat/lower-case-hash
branch
from
8e1d79e to
060de32
Compare
matthewp
reviewed
Aug 21, 2023
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@astrojs/compiler': patch | |||
There was a problem hiding this comment.
probably should be major I guess, right?
There was a problem hiding this comment.
I really don't know to be honest. If users rely on this, then yes it makes sense.
What do you think?
There was a problem hiding this comment.
idk, always have a hard time judging these grey-area changes. Happy with whatever @natemoo-re thinks.
matthewp
approved these changes
Aug 21, 2023
natemoo-re
approved these changes
Aug 21, 2023
ematipico
commented
Aug 21, 2023
|
Thank you. I updated the changelog, to give a better explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR changes the hash emitted by the compiler, by making it lower-case.
Testing
I updated all the test cases. The current CI should pass.
Docs
Internal change, is not needed