Add regression test for #776 #901
Conversation
|
| { | ||
| name: "Component before html II", | ||
| source: `<MainHead title={title} description={description} /><html lang="en"><body><slot /></body></html>`, | ||
| want: `<MainHead title={title} description={description}></MainHead><slot></slot>`, |
There was a problem hiding this comment.
The output looks incorrect but I believe it's intended?
(though this isn't related to this PR or #891. I'll open an issue so we can discuss about it)
There was a problem hiding this comment.
Hmm, both of these seem incorrect, to be honest. I'd expect the <html> and <body> to be preserved.
There was a problem hiding this comment.
Could we maybe merge this for now and close the issue as it wasn't actually about the incorrect markup, but the index out of range errors which have been fixed?
This bug apparently existed since at least v1.3.0 (which is the oldest version my playground supports) for normal elements.
I opened a new issue for this specific bug #913
Changes
Add a regression test for #776. The issue has been fixed in #891
Testing
Added a transform test
Docs
N/A bug fix, though ultimately, I think we want to discourages things like using elements before html.