Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect table parsing when it contains expressions in certain cases #925

Merged
merged 7 commits into from
Jan 2, 2024

Conversation

MoustaphaDev
Copy link
Member

@MoustaphaDev MoustaphaDev commented Dec 23, 2023

Changes

Inside a table element, when there was an implied tr tag which had a td or th which contained an expression (that's a mouthful yeah 😅), it would cause any trailing element/component/text node to be swallowed by the table element (just before the table closing tag). This fixes that.

Testing

Docs

N/A bug fix

Copy link

changeset-bot bot commented Dec 23, 2023

🦋 Changeset detected

Latest commit: 4d23d09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MoustaphaDev
Copy link
Member Author

!preview table-tr-expr-issue

Copy link
Contributor

 > root@0.0.0 release /home/runner/work/compiler/compiler > changeset publish "--tag" "next--table-tr-expr-issue" 🦋 warn ===============================IMPORTANT!=============================== 🦋 warn Packages will be released under the next--table-tr-expr-issue tag 🦋 warn ---------------------------------------------------------------------- 🦋 info npm info @astrojs/compiler 🦋 info @astrojs/compiler is being published because our local version (0.0.0-table-tr-expr-issue-20231223194846) has not been published on npm 🦋 info Publishing "@astrojs/compiler" at "0.0.0-table-tr-expr-issue-20231223194846" 🦋 success packages published successfully: 🦋 @astrojs/compiler@0.0.0-table-tr-expr-issue-20231223194846 🦋 Creating git tag... 🦋 New tag: @astrojs/compiler@0.0.0-table-tr-expr-issue-20231223194846

@MoustaphaDev MoustaphaDev marked this pull request as draft December 23, 2023 20:01
@MoustaphaDev MoustaphaDev marked this pull request as ready for review December 23, 2023 20:17
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you so much for tackling this!

@natemoo-re natemoo-re merged commit 14ccba5 into main Jan 2, 2024
5 checks passed
@natemoo-re natemoo-re deleted the fix-table-issue branch January 2, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astro misparses table HTML 🐛 BUG: Dynamic tables delete following closing tag
2 participants