Prevent printing tagged render function on whitespace only text nodes #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eb1d7bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Whoops, sorry about that! I probably should have merged these in any other order. |
|
No worries! I'm working on this now (and getting weird issues where tests work locally and not on ci), but I'll finish the day soon so I'll probably only be able to get a fix by tomorrow. |
MoustaphaDev
changed the title
This was referenced Jan 3, 2024
natemoo-re
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#930 introduced a regression which broke a test added in #928, but we didn't catch that probably because we didn't update the branch before merging. This fixes the regression and updates tests
Testing
Update tests to account for recently merged changes
Docs
N/A bug fix