Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with head content pushed into body #990

Merged
merged 5 commits into from
Apr 1, 2024
Merged

Fix issue with head content pushed into body #990

merged 5 commits into from
Apr 1, 2024

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • New printer test

Docs

N/A, bug fix

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: a333dfa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthewp matthewp mentioned this pull request Mar 29, 2024
Closed
1 task
@matthewp matthewp changed the title Head regress Fix issue with head content pushed into body Mar 29, 2024
@matthewp
Copy link
Contributor Author

!preview head-body-content

@github-actions GitHub Actions
Copy link
Contributor 

 > root@0.0.0 release /home/runner/work/compiler/compiler > changeset publish "--tag" "next--head-body-content" 🦋 warn ===============================IMPORTANT!=============================== 🦋 warn Packages will be released under the next--head-body-content tag 🦋 warn ---------------------------------------------------------------------- 🦋 info npm info @astrojs/compiler 🦋 info @astrojs/compiler is being published because our local version (0.0.0-head-body-content-20240329154053) has not been published on npm 🦋 info Publishing "@astrojs/compiler" at "0.0.0-head-body-content-20240329154053" 🦋 success packages published successfully: 🦋 @astrojs/compiler@0.0.0-head-body-content-20240329154053 🦋 Creating git tag... 🦋 New tag: @astrojs/compiler@0.0.0-head-body-content-20240329154053

@matthewp
Copy link
Contributor Author

!preview head-body-content

@matthewp
Copy link
Contributor Author

!preview head-body-content

@matthewp
Copy link
Contributor Author

!preview head-body-content

@github-actions GitHub Actions
Copy link
Contributor 

 > root@0.0.0 release /home/runner/work/compiler/compiler > changeset publish "--tag" "next--head-body-content" 🦋 warn ===============================IMPORTANT!=============================== 🦋 warn Packages will be released under the next--head-body-content tag 🦋 warn ---------------------------------------------------------------------- 🦋 info npm info @astrojs/compiler 🦋 info @astrojs/compiler is being published because our local version (0.0.0-head-body-content-20240329184853) has not been published on npm 🦋 info Publishing "@astrojs/compiler" at "0.0.0-head-body-content-20240329184853" 🦋 success packages published successfully: 🦋 @astrojs/compiler@0.0.0-head-body-content-20240329184853 🦋 Creating git tag... 🦋 New tag: @astrojs/compiler@0.0.0-head-body-content-20240329184853

deeprobin
deeprobin approved these changes Mar 29, 2024
View reviewed changes
Copy link

@deeprobin deeprobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewp matthewp mentioned this pull request Apr 1, 2024
Merged
@matthewp matthewp merged commit 5467f40 into main Apr 1, 2024
5 checks passed
@matthewp matthewp deleted the head-regress branch April 1, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@deeprobin deeprobin deeprobin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@matthewp @deeprobin @bluwy