Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update any Vite docs links for their new domain #9548

Closed
sarah11918 opened this issue Oct 3, 2024 · 0 comments · Fixed by #9553
Closed

Update any Vite docs links for their new domain #9548

sarah11918 opened this issue Oct 3, 2024 · 0 comments · Fixed by #9553
Labels
community resource Adds a link to an external community resource, such as a recipe, tutorial or talk. good first issue Good for newcomers help wanted Issues looking for someone to run with them!

Comments

@sarah11918
Copy link
Member

sarah11918 commented Oct 3, 2024 •
edited
Loading

📋 Explain your issue

Vite just updated their domain from vitejs.dev to just vite.dev.

I haven't looked yet, but I'm pretty sure we must link to Vite's documentation at least somewhere in the docs (both main, and 5.0.0-beta branch - I know there is an existing link on the Imports guide page that is only in the beta branch). They have redirects set up, but it would be nice for us to update to their current links!

Would happily accept a PR that:

  • searches our entire repo starting from src/content/docs/ for any mention of vitejs.dev and replaces with vite.dev
  • fixing in other languages is OK! You have my permission!
  • include [i18nIgnore] in the PR title to not affect translation status of any translated pages.
@sarah11918 sarah11918 added good first issue Good for newcomers help wanted Issues looking for someone to run with them! community resource Adds a link to an external community resource, such as a recipe, tutorial or talk. labels Oct 3, 2024
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this issue Oct 3, 2024
@ArmandPhilippot
fix: update Vite links to use their new domain
f0f567b 
See withastro#9548
@ArmandPhilippot ArmandPhilippot mentioned this issue Oct 3, 2024
Merged
ArmandPhilippot added a commit to ArmandPhilippot/astro that referenced this issue Oct 3, 2024
@ArmandPhilippot
docs: update Vite links to use their new domain
d59865b 
See withastro/docs#9548
@ArmandPhilippot ArmandPhilippot mentioned this issue Oct 3, 2024
Merged
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this issue Oct 3, 2024
@ArmandPhilippot
fix: update Vite links to use their new domain
2a6ce93 
See withastro#9548
@ArmandPhilippot ArmandPhilippot mentioned this issue Oct 3, 2024
Merged
Princesseuh added a commit to withastro/astro that referenced this issue Oct 3, 2024
@ArmandPhilippot @Princesseuh
docs: update Vite links to use their new domain (#12117)
a46839a 
* docs: update Vite links to use their new domain

See withastro/docs#9548

* update other links with the new Vite domain

* Create strange-cats-notice.md

---------

Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community resource Adds a link to an external community resource, such as a recipe, tutorial or talk. good first issue Good for newcomers help wanted Issues looking for someone to run with them!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[i18nIgnore] fix: update Vite links to use their new domain ArmandPhilippot/astro-docs
1 participant
@sarah11918