fix: update hook signature

[ematipico]

Description (required)

The documentation is incorrect, and the updateConfig is for vite, not Astro.

I wonder if we should change its name...

Related issues & labels (optional)

I noticed the mistake in withastro/astro#12372

[netlify]

✅ Deploy Preview for astro-docs-2 ready!

Name	Link
🔨 Latest commit	4aed803
🔍 Latest deploy log	https://app.netlify.com/sites/astro-docs-2/deploys/6761836522032e0008d14645
😎 Deploy Preview	https://deploy-preview-10410--astro-docs-2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[astrobot-houston]

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File	Note
en/reference/integrations-reference.mdx	Source changed, localizations will be marked as outdated.

Warnings reference

Icon	Description
🔄️	The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

[sarah11918]

Thank you for fixing @ematipico !

[rbsummers]

Hi there! I think this PR, while necessary, won't close the referred issue because we need some changes in the astro package to have the config matter for vite.build. I've opened a PR to do that but for now I have only manually tested it, I'll need more time to figure out the testing setup

See also https://github.com/withastro/astro/pull/12763/files

[sarah11918]

Thank you @rbsummers -- can you let me know:

Is the proposal in this PR a change to correct, existing behavior or does this change rely on the linked PR being released to be correct?

Docs PRs are merged independently of feature releases, and publish live immediately. So, it's important to know whether this is a fix to incorrect (current, published) documentation, or whether this change is only correct when the linked PR is released in the next patch version of Astro.

It's also OK to have multiple docs PRs if, for example, something is immediately wrong and needs correcting now, but then another PR will be needed to accompany the linked PRs release. I'm just not sure the state of this feature right now, and it would help me to know so I can make sure we're merging at the correct time! 🙌

[rbsummers]

Hi @sarah11918,

It was a tricky situation because the feature was implemented (the function updateConfig was in the code, probably because it mimicked some other function available & well documented in a different hook), but it did nothing and it was not properly documented for this other hook. My PR (which @ematipico merged a bit ago, thank you!) fixed the first point, and this one addresses the second.

If merging this makes the doc change immediately, maybe we need to hold on a bit until the version with the fix (5.0.10 I guess?) is released and then merge.

[ematipico]

If merging this makes the doc change immediately, maybe we need to hold on a bit until the version with the fix (5.0.10 I guess?) is released and then merge.

Fixing the API signature should be done regardless of the fix of the code.

[sarah11918]

@ematipico You have my approval to merge whatever is correct now! I just wasn't sure what was happening. 😄

I agree, if this PR is entirely correct now, my suggestion would be to merge it!

[ematipico]

I updated the PR description to mention that I noticed the mistake in an issue, but PR won't fix it the issue in core.