-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(fr): Add guides/server-islands
from #9240 (v5)
#10474
i18n(fr): Add guides/server-islands
from #9240 (v5)
#10474
Conversation
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (I left two nits)
For île
or îlot
, I'd said we can leave it as it is for now. But, yeah, maybe we should agree on a single term for both this page and Island architecture.
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Heads up we're missing the recently added caching section: 0d5a3f3 |
Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
…veur and #fonctionnalités-de-rendu-à-la-demande Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a duplicated section!
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
Edited! |
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Thanks @ArmandPhilippot for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉 🚀
Description (required)
Add
guides/server-islands
from #9240 (v5).Note
I'm not sure about
îlots
orîles
.Related issues & labels (optional)