Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(fr): Add guides/server-islands from #9240 (v5) #10474

Merged

Conversation

thomasbnt
Copy link
Member

Description (required)

Add guides/server-islands from #9240 (v5).

Note

I'm not sure about îlots or îles.

Related issues & labels (optional)

  • Suggested label: i18n

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 19, 2024
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d4346e3
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67680f31dbf9b800082eff76
😎 Deploy Preview https://deploy-preview-10474--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Dec 19, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
fr/guides/server-islands.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (I left two nits)

For île or îlot, I'd said we can leave it as it is for now. But, yeah, maybe we should agree on a single term for both this page and Island architecture.

src/content/docs/fr/guides/server-islands.mdx Outdated Show resolved Hide resolved
src/content/docs/fr/guides/server-islands.mdx Outdated Show resolved Hide resolved
thomasbnt and others added 3 commits December 20, 2024 15:03
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@yanthomasdev
Copy link
Member

Heads up we're missing the recently added caching section: 0d5a3f3

Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
@thomasbnt
Copy link
Member Author

Heads up we're missing the recently added caching section: 0d5a3f3

Hello, just added with 8f82756

…veur and #fonctionnalités-de-rendu-à-la-demande

Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
Copy link
Contributor

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a duplicated section!

src/content/docs/fr/guides/server-islands.mdx Outdated Show resolved Hide resolved
thomasbnt and others added 2 commits December 22, 2024 14:04
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
@thomasbnt
Copy link
Member Author

Edited!

Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@thomasbnt
Copy link
Member Author

Thanks @ArmandPhilippot for the review!

Copy link
Contributor

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 🚀

@thomasbnt thomasbnt merged commit c6b1555 into withastro:main Dec 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants