-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Document new ActionInputSchema utility type
#12647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Thanks for submitting this documentation with your feature @mauriciabad ! I will also ask @florian-lefebvre to check in on these docs after everything is resolved in the Astro feature PR to make sure what's here matches the decisions made over there! |
florian-lefebvre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming we keep the name so docs can be reviewed!
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting docs to go with your feature, @mauriciabad ! I'll probably also need @ArmandPhilippot to help me with wording here because this is not my area of expertise and I do think we need to adjust the text here to match the Astro docs style.
I've left some comments/questions!
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
|
Thanks everyone for the reviews, I added some comments and suggestions. Make any edits you want, for me all outcomes are okay. |
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
|
@sarah11918 feel free to directly commit the changes you want to make |
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, this one's looking pretty good! Thanks everyone for their help with this one. Should be good to go for 5.16 this week!
|
@yanthomasdev At your leisure.... 😄 |
yanthomasdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!

Description
Documentation for the new
ActionInputSchemautility type I proposed in withastro/astro#14698I put the latest version +1 patch in the
<Since>component, but I don't know the exact version yet.Feel free to change the text if is not clear :)
I also native Spanish, if you want me to translate it.