-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[i18nIgnore] Update backend guides to use logo instead of service
#12759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: deploy-guides-alpha
Are you sure you want to change the base?
Conversation
logo instead of servicelogo instead of service
Lunaria Status Overview🌑 This pull request will not trigger status changes. Learn moreLunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: You can change this by either removing the keyword above from the PR's title, or modifying the Tracked FilesNote The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.
Warnings reference
|
| /:lang/guides/deploy/sst/ /:lang/guides/deploy/aws-via-sst/ | ||
| /:lang/guides/deploy/flightcontrol/ /:lang/guides/deploy/aws-via-flightcontrol/ | ||
| /:lang/guides/deploy/google-firebase/ /:lang/guides/deploy/firebase/ | ||
| /:lang/reference/experimental-flags/sessions/ /:lang/guides/sessions/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that these earlier ones that appear changed is just a matter of using consistent spaces. This PR only introduces two new redirects (at the bottom)
| label: Firebase | ||
| type: backend | ||
| service: Firebase | ||
| logo: firebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that the sidebar.label for these was already "Firebase", so no label changes (and therefore no translation considerations!) needed here.
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
If wanted, we can update backend guides to accompany #12735
(This PR can change base to
mainto publish separately after 12735 is merged, or can merge into that one as this PR has both updated components)Notes:
There should be no translation updates needed (unlike in the Deploy Guide PR) here! Nothing re:
sidebar.labelchanged in any of the guides here!This PR doesn't include support for
tags(like the deploy guides) because we don't currently use a non-minimalversion of this component. We could standardize and allow all components to have a minimal vs showing badges view, even if we don't currently display badges on any other kind of nav grid.