Small build performance improvement #12760
Open
+61
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ArmandPhilippot
approved these changes
Nov 21, 2025
Member
ArmandPhilippot
left a comment
ArmandPhilippot
left a comment
There was a problem hiding this comment.
I checked different pages and couldn't spot any issues with our <Since /> component. I also tested the custom error locally out of curiosity. Well done, and nice saving! 🙌🏽
| const { tagline, link, linkText } = Astro.props; | ||
| type Contributor = { |
Member
There was a problem hiding this comment.
I guess we could now use CollectionEntry<"astroContributors">["data"] to avoid repeating the shape in two different places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
This PR optimizes how we access some remote data during builds to speed them up.
Before: each
<Version>and<Since>component call acachedFetch()function to request package metadata from the npm registry. This resulted in 16 requests for fairly large JSON files like https://registry.npmjs.org/astro/latest.After: a content collection loads the same metadata using a single
fetch()call using the https://npm.antfu.dev service (see https://github.com/antfu/fast-npm-meta). This single fetch returns data ~4x smaller than just one of the previous npm registry calls, so we use ~64x less bandwidth and avoid request overhead by only making one request instead of multiple.While here, I also moved to use the same approach for the contributor data used in our
<FacePile>component on the docs landing page. This meant I could remove ourcachedFetch()utility and reduce our dependencies by 7 packages and 570 KB.In some measurements on Netlify it looks like this might add up to a 15–20s saving in build times. Modest but still handy!