Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getHeadings clean up #1277

Merged
merged 3 commits into from
Aug 13, 2022
Merged

getHeadings clean up #1277

merged 3 commits into from
Aug 13, 2022

Conversation

delucis
Copy link
Member

@delucis delucis commented Aug 12, 2022

What kind of changes does this PR include?

  • New or updated content

Description

Picks up the last few pieces from #1107 that weren’t done yet:

  • API reference: getHeaders() -> getHeadings()
  • Use “headings” over “headers” in Markdown guide
  • Use a codeblock for the return type to avoid awkward linebreaks.

@netlify
Copy link

netlify bot commented Aug 12, 2022 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 18a40af
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/62f73f7f88898c000ab46402
😎 Deploy Preview https://deploy-preview-1277--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarah11918
Copy link
Member

Thanks, @delucis! LGTM! 🥳

@delucis delucis merged commit eaba2e7 into main Aug 13, 2022
@delucis delucis deleted the chris/1107-followup branch August 13, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delucis @sarah11918