Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update integration docs #3105

Merged
merged 1 commit into from
Apr 28, 2023
Merged

ci: update integration docs #3105

merged 1 commit into from
Apr 28, 2023

Conversation

astrobot-houston
Copy link
Contributor

This PR is auto-generated by a nightly GitHub action to update the individual integration pages from the integration READMEs in withastro/astro.

@astrobot-houston astrobot-houston added the ci Automated PRs created by CI, or PRs about automation - ask @delucis for help! label Apr 27, 2023
@netlify
Copy link

netlify bot commented Apr 27, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 40293f3
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/644bb63ed2f8880008d38041
😎 Deploy Preview https://deploy-preview-3105--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarah11918
Copy link
Member

@Yan-Thomas I'm not sure what happened with this one. I checked the original Astro PR ( https://github.com/withastro/astro/pull/6222/files ) and there are the three code back ticks around the code snippet, but it seems like this PR does not seem to include the syntax for the code sample? I think that's why this is failing?

Do you have a chance to look at this? ( no rush!)

@delucis
Copy link
Member

delucis commented Apr 27, 2023

Ah, I’ve seen this before. If a code block in the source README does not include a language, i.e.

```
code here
```

When we generate our pages, remark seems to decide to output that as a code block with only indentation. However that does not work in MDX and the build fails. I tend to go back and add the language to the README (don’t see a good reason for leaving it out).

@yanthomasdev
Copy link
Member

Yes, that looks to be the case here. I'll PR into the README to fix this.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @Yan-Thomas 💜

@delucis delucis merged commit 8f23f15 into main Apr 28, 2023
@delucis delucis deleted the ci/docgen-integrations branch April 28, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Automated PRs created by CI, or PRs about automation - ask @delucis for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants