-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown Recipe #3270
Markdown Recipe #3270
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Hey this looks great @Jothsa! I'm really excited for this! Just a couple of general changes I think we can make to improve the page, then I'll edit more closely:
Can you try recrafting the existing page based on the above, then I'll do a bit of editing, too? |
Thanks for the great feedback, @sarah11918! I'll get on it later this morning |
@sarah11918, it's my understanding that the plugin is created in a file created by the user. Personally, I think it makes more sense to create the file/plugin and then add it to the config. Otherwise, wouldn't you be saying, create a blank file, add it to your config, and then add the plugin code to the file? I'm fine either way, but just wanted to mention it. |
Oh, I get you now. Agreed! Good call! Let's leave that as is, and just make sure prerequisites makes sense. 🙌 |
This needs edits as well 😅 Should have it done by Monday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking amazing, @Jothsa! It feels like such a clean read!
I added a couple of suggestions, mostly for standardizing things: packages/properties etc should all use the code formatting when referring to them by name (instead of e.g. talking "about" the title of your page in a paragraph), and Markdown is always capitalized in prose. :)
I also thought we could add a little more context around step 4. See what you think!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Thanks! |
Looking good! I just checked the Netlify deploy preview, and can you see that the content isn't indented inside all the steps like the other recipes are? e.g. if you check another docs page like https://deploy-preview-3270--astro-docs-2.netlify.app/en/recipes/build-forms-api/ you'll see the content is indented so that the numbered steps create a new left margin. This should just be a matter of indenting content within each step, but check another recipe page to be sure. Once we get the formatting to match the others, I think this is good to go! 🥳 |
Whoops. Thanks! Should be fixed now |
Let's do this! |
What kind of changes does this PR include?
Description
Let me know if I should do any other examples from the page.