Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add astro preferences CLI reference #5512

Merged
merged 10 commits into from
Dec 5, 2023
Merged

Add astro preferences CLI reference #5512

merged 10 commits into from
Dec 5, 2023

Conversation

natemoo-re
Copy link
Member

Description (required)

Adds astro preferences to the CLI reference page

Related issues & labels (optional)

  • Suggested label: 4.0, merge-on-release

For Astro version: 4.0.0. See astro PR #9115.

@natemoo-re natemoo-re added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) 4.0 labels Nov 27, 2023
Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 5, 2023 4:25pm

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, after renaming, @natemoo-re !

What would be helpful though is a note about what all people can configure. How do they know which things can be configured at the user level? You mention the list command to show all the user preferences... is that only the ones they specifically set, or is that an exhaustive list (including defaults) so they know what they can change?

That would be my only request, is if we can make it clear how people know what they can even configure! 🙌

src/content/docs/en/reference/cli-reference.mdx Outdated Show resolved Hide resolved
src/content/docs/en/reference/cli-reference.mdx Outdated Show resolved Hide resolved
@sarah11918 sarah11918 added the Docs is happy if OP is happy! Please review your PR and make sure you accept our proposed changes! label Dec 3, 2023
natemoo-re and others added 2 commits December 4, 2023 10:15
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! and removed Docs is happy if OP is happy! Please review your PR and make sure you accept our proposed changes! labels Dec 4, 2023
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nate built it properly, so we could document it properly!

@sarah11918 sarah11918 merged commit 9d88a55 into main Dec 5, 2023
5 of 6 checks passed
@sarah11918 sarah11918 deleted the next-cli-preferences branch December 5, 2023 16:06
dreyfus92 added a commit that referenced this pull request Jan 14, 2024
…mdx` (#6363)

* i18n(fr) Update reading-time.mdx

Just for translator tracker because the PR #5766 should have been [ignore]

* Update astro-pages.mdx

* Update framework-components.mdx

* Update layouts.mdx

* Update routing.mdx

* Update editor-setup.mdx

* Update configuring-astro.mdx

* Update cloudflare.mdx

* Update deno.mdx

* Update netlify.mdx

* Update vercel.mdx

* Update imports.mdx

* Update auto.mdx

* Update manual.mdx

* Update cli-reference.mdx

Update and del some parts

* Update cli-reference.mdx

Update fiule with PR #5512 #5651 #5604 #5765 #6040 #6043 #6109 #6267

* Update auto.mdx

* Update cloudflare.mdx

fix PR #5284

* Update markdown-content.mdx

* Update auto.mdx

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/core-concepts/framework-components.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/core-concepts/framework-components.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/guides/markdown-content.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/install/manual.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/install/manual.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/reference/cli-reference.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Apply suggestions from code review

---------

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
…mdx` (#6363)

* i18n(fr) Update reading-time.mdx

Just for translator tracker because the PR #5766 should have been [ignore]

* Update astro-pages.mdx

* Update framework-components.mdx

* Update layouts.mdx

* Update routing.mdx

* Update editor-setup.mdx

* Update configuring-astro.mdx

* Update cloudflare.mdx

* Update deno.mdx

* Update netlify.mdx

* Update vercel.mdx

* Update imports.mdx

* Update auto.mdx

* Update manual.mdx

* Update cli-reference.mdx

Update and del some parts

* Update cli-reference.mdx

Update fiule with PR #5512 #5651 #5604 #5765 #6040 #6043 #6109 #6267

* Update auto.mdx

* Update cloudflare.mdx

fix PR #5284

* Update markdown-content.mdx

* Update auto.mdx

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/core-concepts/framework-components.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/core-concepts/framework-components.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/guides/markdown-content.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/install/manual.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/install/manual.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/reference/cli-reference.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Apply suggestions from code review

---------

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.0 add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants