Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add extendable CSSProperties interface #6062

Merged
merged 3 commits into from
Jan 4, 2024
Merged

docs: add extendable CSSProperties interface #6062

merged 3 commits into from
Jan 4, 2024

Conversation

jjenzz
Copy link
Contributor

@jjenzz jjenzz commented Jan 3, 2024 •
edited
Loading

Description (required)

TypeScript instructions for extending the CSSProperties interface. Used for adding typed custom properties to style attribute.

CleanShot.2024-01-03.at.00.44.49.mp4

Related issues & labels (optional)

For Astro version: 4.0.10. See astro PR #9587.

@vercel Vercel
Copy link

vercel bot commented Jan 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 4, 2024 3:37am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Jan 4, 2024 3:37am

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@jjenzz jjenzz mentioned this pull request Jan 3, 2024
Merged
@jjenzz jjenzz marked this pull request as draft January 3, 2024 00:28
@jjenzz jjenzz force-pushed the css-properties-interface branch from d272d4a to d151f44 Compare January 3, 2024 00:43
@jjenzz jjenzz force-pushed the css-properties-interface branch from d151f44 to 4acb409 Compare January 3, 2024 00:44
@jjenzz jjenzz marked this pull request as ready for review January 3, 2024 00:47
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Jan 3, 2024
@sarah11918 sarah11918 added this to the 4.1.0 milestone Jan 3, 2024
@sarah11918 @yanthomasdev
sentence formatting
64a7aa4 
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
sarah11918
sarah11918 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @jjenzz ! I'm approving this as ready for the 4.1 minor release (since that will happen instead of a 4.0.10). It will merge tomorrow, and we're thrilled to welcome you to Team Docs! 🥳

@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label Jan 3, 2024
@sarah11918 sarah11918 changed the base branch from main to 4.1.0 January 3, 2024 17:32
@sarah11918 sarah11918 merged commit 3b58fd6 into withastro:4.1.0 Jan 4, 2024
3 of 4 checks passed
@jjenzz jjenzz deleted the css-properties-interface branch January 6, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanthomasdev yanthomasdev yanthomasdev left review comments

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jjenzz @astrobot-houston @sarah11918 @yanthomasdev