Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cloudflare.mdx #6150

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Update cloudflare.mdx #6150

merged 5 commits into from
Jan 9, 2024

Conversation

alexanderniebuhr
Copy link
Member

@alexanderniebuhr alexanderniebuhr commented Jan 5, 2024 •
edited
Loading

Description (required)

@vercel Vercel
Copy link

vercel bot commented Jan 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 9, 2024 3:26pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2024 3:26pm

@alexanderniebuhr alexanderniebuhr added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label Jan 5, 2024
@alexanderniebuhr
Copy link
Member Author

Even if this does not depend on core PR, it does depend on the linked adapters PR. So I still added merge-on-release, let me know if that was wrong ❤️

sarah11918
sarah11918 reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexanderniebuhr - Quick thought re: the description below, and how we can maybe avoid having a caution by getting the idea across in the description itself!

src/content/docs/en/guides/integrations-guide/cloudflare.mdx Outdated Show resolved Hide resolved
@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Jan 5, 2024
sarah11918
sarah11918 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarah11918
Copy link
Member

@alexanderniebuhr Can you please update the PR description to include the version number of Cloudflare this is to be released with? It just helps us when scanning. Any maintainer can merge when they notice the announcement post of the correct version, if by chance this slips your attention when the next minor is released.

@sarah11918
Copy link
Member

@alexanderniebuhr Heads up there's now a conflict to resolve here!

@alexanderniebuhr alexanderniebuhr merged commit 78d17fa into main Jan 9, 2024
8 checks passed
@alexanderniebuhr alexanderniebuhr deleted the nbhr/docs-adapters-58 branch January 9, 2024 15:30
@huyikai huyikai mentioned this pull request Jan 10, 2024
Merged
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@alexanderniebuhr @sarah11918 @ematipico
Update cloudflare.mdx (#6150)
41d1161 
* Update cloudflare.mdx

* Update src/content/docs/en/guides/integrations-guide/cloudflare.mdx

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update cloudflare.mdx

---------

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderniebuhr @sarah11918