-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use eslint #710
Use eslint #710
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
If you are using VS Code and ESLint extension, you can also check in the editor by adding the following settings to {
"eslint.validate": [
"javascript",
"javascriptreact",
"astro",
"typescript",
"typescriptreact"
]
} https://github.com/ota-meshi/eslint-plugin-astro#visual-studio-code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ota-meshi!
Thanks so much for taking the time to add this 🙌
I have a couple of questions about the config/plugin, but in general this looks great.
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
What kind of changes does this PR include?
Description
close #634
This PR introduces ESLint to the project. And, add the npm script
"lint:eslint"
to run ESLint.I also made some simple fixes to some of the warned files.
However, the eslint configuration may need to be changed. Currently, it is based on the recommended configuration of eslint and each eslint plugin.
There are no visual changes.