Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit: new indexes config #7639

Merged
merged 4 commits into from
Apr 9, 2024
Merged

edit: new indexes config #7639

merged 4 commits into from
Apr 9, 2024

Conversation

bholmesdev
Copy link
Contributor

Description (required)

Update indexes configuration from an object to an array. Also note that index names are generated with a name property to override.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 27, 2024 10:19pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Mar 27, 2024 10:19pm

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @bholmesdev ! Just a few quick things below. You know the drill: if it's not released yet, add the merge on release label. If it is, go ahead and merge when you're happy!

src/content/docs/en/guides/integrations-guide/db.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/integrations-guide/db.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/integrations-guide/db.mdx Outdated Show resolved Hide resolved
@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Mar 27, 2024
bholmesdev and others added 3 commits March 27, 2024 18:03
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@bholmesdev bholmesdev added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label Mar 27, 2024
@sarah11918
Copy link
Member

sarah11918 commented Apr 9, 2024

@bholmesdev Just a quick check that this looks like it can be merged now? Normally we let maintainers keep track of their own feature docs that aren't part of a coordinated minor effort.

Happy to merge this for you if needed, but this is also the kind of thing you can come and merge when your patch goes out!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Apr 9, 2024
@bholmesdev
Copy link
Contributor Author

Ah! This should have been merged a while ago. Yes plesae

@bholmesdev bholmesdev merged commit 4d5c2e0 into main Apr 9, 2024
7 checks passed
@bholmesdev bholmesdev deleted the feat/indexes-config-rework branch April 9, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants