Update "Fragments & Multiple Elements" examples #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sarah11918
added
the
improve or update documentation
sarah11918
commented
Jun 16, 2022
delucis
reviewed
Jun 19, 2022
There was a problem hiding this comment.
I thought we decided to keep the fragment wrapping example? The reason being that without the <></> this code breaks if you leave out the wrapping () which is less easy for people to spot as important when following this example.
We can probably relax the phrasing to be less insistent (“must” etc.) though.
|
You're right! It's a good example in and of itself. I'll bring it back in, with less strong wording. Thoughts on the added example re: good use of |
delucis
reviewed
Jun 20, 2022
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
sarah11918
commented
Jun 22, 2022
|
Changes incorporated, @delucis ! Care to take another once-over and see how it looks altogether? |
delucis
reviewed
Jun 22, 2022
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
yanthomasdev
added a commit
that referenced
this pull request
Jun 22, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #369
This updates our Muliple Elements example to avoid telling people they MUST use a wrapping element when they don't have to.
Further adds an example of using Fragment to show when it might be useful to do so, since they don't appear to be necessary.