Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed getHeaders() to getHeadings(), according to RFC #208. Depends on astro/#3627 #791

Closed
wants to merge 5 commits into from

Conversation

felixsanz
Copy link
Contributor

@felixsanz felixsanz commented Jun 17, 2022

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)
  • New or updated content
  • Translated content
  • Changes to the docs site code
  • Something else!

Description

This PR deprecates getHeaders() documentation in favor of getHeadings(). According to the HTML spec, these are headings. The only part of the spec where the word "headers" appear is in the context of

tag. MDN also uses headings to refer the tags.

Depends on withastro/astro#3627

  • What does this PR change? Give us a brief description.
  • Did you change something visual? A before/after screenshot can be helpful.

1655482510

@netlify
Copy link

netlify bot commented Jun 17, 2022

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5645c1c
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/62aca69cca8ea6000867d9d0
😎 Deploy Preview https://deploy-preview-791--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarah11918 sarah11918 marked this pull request as draft June 17, 2022 18:25
@delucis delucis added the tsc guidance required from Technical Steering Committee label Jul 20, 2022
@natemoo-re
Copy link
Member

Closing in favor of #1107

@natemoo-re natemoo-re closed this Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tsc guidance required from Technical Steering Committee
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants