Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "outDir": "./dist" to tsconfig.json #853

Merged
merged 2 commits into from
Jun 26, 2022
Merged

Add "outDir": "./dist" to tsconfig.json #853

merged 2 commits into from
Jun 26, 2022

Conversation

inwardmovement
Copy link
Contributor

Add "outDir": "./dist" to tsconfig.json to fix "Cannot write file '.../astro.config.mjs" because it would overwrite input file.` error.

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)
  • New or updated content
  • Translated content
  • Changes to the docs site code
  • Something else!

Description

  • What does this PR change? Give us a brief description.
  • Did you change something visual? A before/after screenshot can be helpful.

Add "outDir": "./dist" to tsconfig.json to fix "Cannot write file '.../astro.config.mjs" because it would overwrite input file.` error.
@netlify
Copy link

netlify bot commented Jun 26, 2022

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7774f07
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/62b81bbf2673350007726708
😎 Deploy Preview https://deploy-preview-853--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@delucis delucis added the help - confirm behaviour Walk through the example/issue and confirm this is a general behaviour, or a correct update to make. label Jun 26, 2022
@delucis
Copy link
Member

delucis commented Jun 26, 2022

Hi @inwardmovement — thanks for this!

I've never noticed this error in projects I'm working on, so I'm wondering what's triggering it for you and if this is something we should document universally or not 🤔

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, looks like my projects already had outDir configured!

Thanks for the contribution 💜

@delucis delucis merged commit 28a3bfa into withastro:main Jun 26, 2022
@inwardmovement inwardmovement deleted the patch-1 branch July 1, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help - confirm behaviour Walk through the example/issue and confirm this is a general behaviour, or a correct update to make.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants