Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update editor-setup.mdx to mention new Webstorm features. #9073

Merged
merged 8 commits into from
Aug 15, 2024

Conversation

AdamGEmerson
Copy link
Contributor

Added a note on Webstorm's new language server support.

Description (required)

Just wanted to make a note on the new Astro support features that rolled out for Webstorm today.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

Discord is @zilchgood

Added note on Webstorm's new language server support.
Copy link

netlify bot commented Aug 13, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5346316
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66be2fbe90643e00081ab3f0
😎 Deploy Preview https://deploy-preview-9073--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Aug 13, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en editor-setup.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How exciting @AdamGEmerson ! Thank you for coming and updating our docs. I know we have many JetBrains users who will be really happy about this.

See my comments below re: making this more formal "documentation" vs making this feel like "news." I think that's the appropriate take here. Happy to hear your thoughts! 🙌

src/content/docs/en/editor-setup.mdx Outdated Show resolved Hide resolved
AdamGEmerson and others added 2 commits August 13, 2024 19:27
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Added link to official webstorm docs.
@AdamGEmerson
Copy link
Contributor Author

@Princesseuh @sarah11918

Okay, things look pretty good to me. What do you think?

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for your patience and efforts with this @AdamGEmerson . Welcome to Team Docs! 🥳

@sarah11918 sarah11918 added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Aug 14, 2024
@sarah11918 sarah11918 removed the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Aug 14, 2024
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @AdamGEmerson 🙌

@yanthomasdev yanthomasdev merged commit a5e4015 into withastro:main Aug 15, 2024
10 checks passed
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Aug 16, 2024
Add changes from withastro#9073 about Webstorm
yanthomasdev added a commit that referenced this pull request Aug 16, 2024
Add changes from #9073 about Webstorm

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants