-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document swapFunctions of astro:transitions/client #9084
Merged
+40
−10
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2e266c0
Document swapFunctions of astro:transitions/client
martrapp 5f8cc04
+ Since
martrapp c4c617d
Merge branch 'main' into mt/swapFunctions
martrapp f86d502
updates version for since
martrapp 3b03011
Update src/content/docs/en/guides/view-transitions.mdx
martrapp b14b60f
Update src/content/docs/en/guides/view-transitions.mdx
martrapp 2cc4f59
slightly rephrased
martrapp 8595195
substitute `ev` with `event`
martrapp 1420df9
Merge branch 'main' into mt/swapFunctions
sarah11918 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last tiny tiny thing: assuming that
ev
stands forevent
, we generally prefer to write these words out in full as they can help people who aren't used to standard abbreviations. This would be my preference, if correct!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one! I had used
ev
for consistency with the rest of the page. Now everything is consistent again ;-)