Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(ko-KR): update api-reference.mdx #9245

Merged
merged 8 commits into from
Aug 30, 2024
Merged

i18n(ko-KR): update api-reference.mdx #9245

merged 8 commits into from
Aug 30, 2024

Conversation

jsparkdev
Copy link
Contributor

@jsparkdev jsparkdev commented Aug 29, 2024 •
edited
Loading

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Aug 29, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 29, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 871dbf4
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66d20cc0a3ae8c0008ab9720
😎 Deploy Preview https://deploy-preview-9245--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Aug 29, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
ko reference/api-reference.mdx Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

yanthomasdev
yanthomasdev reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsparkdev, from what I can see we're missing some changes from the last two commits, could you take a look? https://github.com/withastro/docs/commits/main/src/content/docs/en/reference/api-reference.mdx?since=2024-08-23T16:20:02.000Z

dreyfus92
dreyfus92 reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @jsparkdev, I left a couple of suggestions and also there is a part missing like Yan mentioned

src/content/docs/ko/reference/api-reference.mdx Outdated Show resolved Hide resolved
src/content/docs/ko/reference/api-reference.mdx Outdated Show resolved Hide resolved
src/content/docs/ko/reference/api-reference.mdx Outdated Show resolved Hide resolved
jsparkdev and others added 3 commits August 30, 2024 11:47
@jsparkdev @dreyfus92
Update src/content/docs/ko/reference/api-reference.mdx
738ee77 
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
@jsparkdev @dreyfus92
Update src/content/docs/ko/reference/api-reference.mdx
9956746 
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
@jsparkdev @dreyfus92
Update src/content/docs/ko/reference/api-reference.mdx
0ef151a 
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
@jsparkdev jsparkdev marked this pull request as draft August 30, 2024 04:09
@jsparkdev jsparkdev marked this pull request as ready for review August 30, 2024 05:09
yanthomasdev
yanthomasdev approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Amazing work! 💜

@yanthomasdev yanthomasdev merged commit b93d48c into withastro:main Aug 30, 2024
10 checks passed
@jsparkdev jsparkdev deleted the api-ref branch August 31, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreyfus92 dreyfus92 dreyfus92 left review comments

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsparkdev @astrobot-houston @yanthomasdev @dreyfus92