Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info about propertiesToHash to image-service-reference.mdx #9505

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Add info about propertiesToHash to image-service-reference.mdx #9505

merged 3 commits into from
Sep 30, 2024

Conversation

amxmln
Copy link
Contributor

@amxmln amxmln commented Sep 27, 2024

Description

Local image services have a property propertiesToHash which is missing from the docs. This change adds it along with a short explanation of what it does and what it falls back to if not passed.

Related issues & labels (optional)

@amxmln
Add info about propertiesToHash to image-service-reference.mdx
1c4b0c5 
Local image services have a property `propertiesToHash` which is missing from the docs. This change adds it along with a short explanation of what it does and what it falls back to if not passed.
@netlify Netlify
Copy link

netlify bot commented Sep 27, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d747073
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66faeb45ea2cd60008ca0677
😎 Deploy Preview https://deploy-preview-9505--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Sep 27, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en reference/image-service-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918
Copy link
Member

Thank you for this PR! I'll ask @Princesseuh to give a technical review, and to confirm that this information is added in the best place!

Princesseuh
Princesseuh approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you!

sarah11918
sarah11918 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We love it when issues work out like this! Thank you @amxmln , and welcome to Team Docs! 🥳

@sarah11918 sarah11918 added improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Sep 27, 2024
yanthomasdev
yanthomasdev approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work 🙌

@yanthomasdev yanthomasdev merged commit 92e12ba into withastro:main Sep 30, 2024
10 checks passed
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Sep 30, 2024
@thomasbnt
i18n(fr): Update reference/image-service-reference.mdx from withast…
c2a3e10 
…ro#9505

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt thomasbnt mentioned this pull request Sep 30, 2024
Merged
yanthomasdev pushed a commit that referenced this pull request Sep 30, 2024
@thomasbnt @ArmandPhilippot
i18n(fr): Update reference/image-service-reference.mdx from #9505 (#…
e55a239 
…9514)

* i18n(fr): Update `reference/image-service-reference.mdx` from #9505

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* Update src/content/docs/fr/reference/image-service-reference.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

---------

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@jsparkdev jsparkdev mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@Princesseuh Princesseuh Princesseuh approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees
No one assigned
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

propertiesToHash missing from Image Service API Docs
5 participants
@amxmln @astrobot-houston @sarah11918 @Princesseuh @yanthomasdev