Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update upgrade guide #9507

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

florian-lefebvre
Copy link
Member

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit b4dc12f
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66faa1bcf0a5470007d8f713
😎 Deploy Preview https://deploy-preview-9507--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @florian-lefebvre - can you also add around l ine 487 in the code removal section, and update the line highlighting?

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks great! Ready to merge whenever you're ready! (I suppose no harm if this one merges early, suggesting that people remove CCC flag.)

@florian-lefebvre florian-lefebvre merged commit dcd0d0f into 5.0.0-beta Sep 30, 2024
5 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/next-remove-ccc branch September 30, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants