-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18nIgnore] feat: remove Astro Studio references #9509
base: main
Are you sure you want to change the base?
Conversation
removed any studio references from guides\integrations-guide\db.mdx
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌑 This pull request will not trigger status changes. Learn moreLunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: You can change this by either removing the keyword above from the PR's title, or modifying the Tracked FilesNote The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome start! Left some ideas on how the pages could be changed. Nothing set in stone tho
Co-Authored-By: Luiz Ferraz <luiz@lferraz.com>
Thank you @casungo for kicking this off, and thanks for jumping in early @Fryuni ! I love where this is going, how you've already realized that the existing structure was a result of the various parts that were added at different times, and want to emphasize that we have TOTAL CONTROL over where this page goes now. One bit of context from the original page: we really did need to keep "Astro DB" stuff separate from "Studio" stuff, which meant explaining as much of the Astro DB stuff first, and then thinking about "connecting to your database" as something separate and difference. But maybe looking at the process as a whole, that's not the way people think of "using a database" in their project, and we don't have to be beholden to any of the original structure! In light of that flexibility, some things I knew I would consider:
|
First off thank you for the comment, gave me a new perspective on how to approach this
I think that we should "guide" the user, at least trough the initial setup to have them in the mindset that once you set 2 env variables you are good and the rest of the things to do are either to seeds your database from zero or to copy how your database is already structured. The actions doc is a great writeup and I think by borrowing a few aspect of it the db page will feel like a page for a completly new feature (not that db is old, or maybe it is old by astro standards where if you blink you miss 3 major releases of everything) Based on this, I think that the page should have a structure like this:
|
I love that idea for a structure! Would you be up for taking a shot at reorganizing it yourself? |
Currently I'm on vacation till next Monday so I doubt I can draft something up these days, but after this week I'll tackle this for sure (or if someone precedes me i can review the changes) :) |
Oh, no worries! Enjoy your vacation! Let's see what we've come up with by the time you're back! |
…/casungo/astroDocs into feat/remove-studio-and-rework-db
Alright! I took a shot at this, trying to think of a reasonable process re: how you might think of this. Completely open to thoughts and suggestions! Note, since we're going to merge this soon, to the main branch, we should keep the "Migrate from Studio" up for a while longer, just in case it's helpful to people who are still migrating. I would have to check on the exact date, but I think people will still have access for a while yet (maybe can't make new DBs etc, but at least to get their data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as someone who's never used Astro Studio nor Astro DB! Just a tiny typo.
I still have an interrogation. From what I understand, in development mode, there is nothing to configure: Astro takes care of generating a database from two files (db/config.ts
and db/seed.ts
)... but generate where? Is a .db
file generated in the db
directory or in .astro/
? Do I have access to it? Can I see how the data is generated?
My question may be stupid, as I said I am not used to Astro DB, but from where I stand I tell myself that it could be important information if someone needs to debug code related to their database. Maybe this scenario never happens... and I'm just curious to better understand how it works locally. 😄 So would it make sense to specify this information in the documentation?
This PR removes any Astro Studio reference since the platform is being sunset.
It needs to be evalued if a notice + mini-guide for migration should be included till the very end of the platform (in like 1 year).