-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent type checking define:vars
scripts
#718
Conversation
🦋 Changeset detectedLatest commit: 042bb0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
const extension = getScriptType(node) === "processed module" ? "mts" : "mjs"; | ||
embeddedScripts.push({ | ||
fileName: fileName + `.${scriptIndex}.mts`, | ||
fileName: fileName + `.${scriptIndex}.${extension}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the fix is here, the rest is clerical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment on the changeset, looks great otherwise. Thank you!
@@ -0,0 +1,5 @@ | |||
--- | |||
'@astrojs/language-server': patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the VS Code package and the Astro check ones to this changeset so they also get a release for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't their semver ranges include this release?
Changes
define:vars
on script tag #711Testing
Manually tested against this snippet:
Docs
Does not affect usage