Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent type checking define:vars scripts #718

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Prevent type checking define:vars scripts #718

merged 3 commits into from
Dec 7, 2023

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Dec 6, 2023

Changes

Testing

Manually tested against this snippet:
---
export interface Props {
  server: string;
}

const { server } = Astro.props;
---

<div id="waline"></div>
<script>
  import { init } from "https://unpkg.com/@waline/client@v2/dist/waline.mjs";
  const x = 43
  init({
    el: "#waline",
    serverURL,
  });
</script>
<script define:vars={{ serverURL: server }} type="module">
  import { init } from "https://unpkg.com/@waline/client@v2/dist/waline.mjs";
  const x = 42
  init({
    el: "#waline",
    serverURL,
  });
</script>
<script is:inline>
	const x = 43
</script>
<script is:inline>
	const x = 44
</script>

Docs

Does not affect usage

Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: 042bb0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@astrojs/language-server Patch
@astrojs/check Patch
astro-vscode Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines +68 to +70
const extension = getScriptType(node) === "processed module" ? "mts" : "mjs";
embeddedScripts.push({
fileName: fileName + `.${scriptIndex}.mts`,
fileName: fileName + `.${scriptIndex}.${extension}`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix is here, the rest is clerical

Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on the changeset, looks great otherwise. Thank you!

@@ -0,0 +1,5 @@
---
'@astrojs/language-server': patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the VS Code package and the Astro check ones to this changeset so they also get a release for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't their semver ranges include this release?

@Princesseuh Princesseuh merged commit dc98b0b into main Dec 7, 2023
4 checks passed
@Princesseuh Princesseuh deleted the fix/711 branch December 7, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript warning when using define:vars on script tag
2 participants