Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(de): update translation reference/overrides #2480

Merged
merged 5 commits into from
Oct 22, 2024
Merged

i18n(de): update translation reference/overrides #2480

merged 5 commits into from
Oct 22, 2024

Conversation

trueberryless
Copy link
Contributor

@trueberryless trueberryless commented Oct 14, 2024 •
edited
Loading

Description

Translation of reference/overrides.mdx into German language.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1aa1a7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Oct 14, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 14, 2024 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 1aa1a7c
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6717777c8ab6a10008ccd880
😎 Deploy Preview https://deploy-preview-2480--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Oct 14, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
de reference/icons.mdx Localization changed, will be marked as complete.
de reference/overrides.md Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@trueberryless
Copy link
Contributor Author

Link fixed in #2459

@trueberryless trueberryless mentioned this pull request Oct 20, 2024
Merged
HiDeoo
HiDeoo requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new translation 👍

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist. I left one comment regarding a missing change and linked to the discussion regarding the sidebar label changes for reference until we know which style should be used.

docs/src/content/docs/de/reference/overrides.md Show resolved Hide resolved
docs/src/content/docs/de/reference/overrides.md
@@ -1,8 +1,10 @@
---
title: Komponenten-Ersetzung Referenz
description: Ein Überblick über die Komponenten und Komponentenprops, die von Starlight Ersetzungen unterstützt werden.
title: Ersetzung von Komponenten Referenz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related discussion for reference https://github.com/withastro/starlight/pull/2470/files/2b486d1b1fa4acf3f0c87da750f3ce219794f78e#diff-9185fd84aba7e9a14b394be96e2bd3562baac10c0285be708a3109c5cbe72802

docs/src/content/docs/de/reference/icons.mdx
Comment on lines +4 to +5
sidebar:
label: Symbole
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related disccussion for reference https://github.com/withastro/starlight/pull/2470/files/2b486d1b1fa4acf3f0c87da750f3ce219794f78e#diff-9185fd84aba7e9a14b394be96e2bd3562baac10c0285be708a3109c5cbe72802

@trueberryless
Copy link
Contributor Author

Thanks for the review, should be good to go when links are ready!

HiDeoo
HiDeoo approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And links are now fixed, everything looks in order, thanks for the updates 🚀

@HiDeoo HiDeoo merged commit 8437c21 into withastro:main Oct 22, 2024
15 checks passed
@trueberryless trueberryless deleted the i18n-ref-ove branch October 22, 2024 11:46
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Oct 23, 2024
@HiDeoo
Merge branch 'main' into hd-perf-sidebar-cache
bc649ce 
* main: (240 commits)
  i18n(de): update some files for consistency in German language (withastro#2502)
  i18n(zh-cn): Update `plugins.mdx` (withastro#2501)
  i18n(de): translate guides/pages (withastro#2469)
  i18n(de): translate components/code (withastro#2457)
  i18n(de): translate components/using-components (withastro#2455)
  [ci] format
  i18n(de): translate guides/site-search (withastro#2481)
  i18n(de): update translation guides/customization (withastro#2475)
  i18n(de): update translation manual-setup (withastro#2479)
  i18n(de): update translation reference/overrides (withastro#2480)
  i18n(de): translate reference/plugins (withastro#2464)
  i18n(de): update translation guides/authoring-content (withastro#2458)
  [ci] format
  i18n(de): update translation reference/configuration (withastro#2459)
  i18n(de): update translation reference/frontmatter (withastro#2470)
  [ci] format
  i18n(de): update translation guides/i18n (withastro#2476)
  i18n(de): update `resources/plugins.mdx` (withastro#2498)
  i18n(ko-KR): update `plugins.mdx` (withastro#2500)
  i18n(fr): Update `resources/plugins` from withastro#2493 (withastro#2496)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trueberryless @astrobot-houston @HiDeoo