Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new plugins to Starlight (resources/plugin.mdx) #2549

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

trueberryless
Copy link
Contributor

@trueberryless trueberryless commented Oct 31, 2024

Description

1000 thanks to @HiDeoo the actual idea for such a plugin was their idea! (I just changed the visuals a bit)

Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: 1921e6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 📚 docs Documentation website changes label Oct 31, 2024
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 1921e6d
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6724fbeea05789000884fa4f
😎 Deploy Preview https://deploy-preview-2549--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Oct 31, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en resources/plugins.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor

@apatel369 apatel369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trueberryless! Just left one suggestion 🙌

docs/src/content/docs/resources/plugins.mdx Show resolved Hide resolved
@HiDeoo HiDeoo merged commit ab9fbc3 into withastro:main Nov 1, 2024
15 checks passed
@trueberryless trueberryless deleted the new-plugin-thx-hideoo branch November 1, 2024 16:10
@trueberryless trueberryless changed the title Add new plugin to Starlight (resources/plugin.mdx) Add new plugin*s to Starlight (resources/plugin.mdx) Nov 1, 2024
@trueberryless trueberryless changed the title Add new plugin*s to Starlight (resources/plugin.mdx) Add new plugin**s** to Starlight (resources/plugin.mdx) Nov 1, 2024
@trueberryless trueberryless changed the title Add new plugin**s** to Starlight (resources/plugin.mdx) Add new plugins to Starlight (resources/plugin.mdx) Nov 1, 2024
@trueberryless
Copy link
Contributor Author

I updated the description so now it fits the new added commits.

Good job to everyone and a huge thanks again @HiDeoo for creating such a beautiful plugin for Starlight!

thomasbnt added a commit to thomasbnt/starlight that referenced this pull request Nov 4, 2024
HiDeoo added a commit that referenced this pull request Nov 5, 2024
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants