Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add issue and discussion templates for documentation improvements #2619

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Add issue and discussion templates for documentation improvements #2619

merged 1 commit into from
Nov 20, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Nov 19, 2024

Description

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 2c8e208

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Nov 19, 2024 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 2c8e208
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/673ce0dcab95d80008d13ead
😎 Deploy Preview https://deploy-preview-2619--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

size-limit report 📦

Path Size
/index.html 6.15 KB (0%)
/_astro/*.js 22.41 KB (0%)
/_astro/*.css 13.73 KB (0%)

sarah11918
sarah11918 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

trueberryless
trueberryless approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool additions!

@delucis delucis merged commit 3548fc3 into main Nov 20, 2024
15 checks passed
@delucis delucis deleted the chris/docs-templates branch November 20, 2024 10:59
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Nov 22, 2024
@HiDeoo
Merge branch 'main' into hd-astro-v5
1c5bdb6 
* main:
  Add issue and discussion templates for documentation improvements (withastro#2619)
  [ci] release (withastro#2618)
  Fix language switcher `trailingSlash` edge case (withastro#2616)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueberryless trueberryless trueberryless approved these changes

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing a GitHub issue form template for docs issues
4 participants
@delucis @astrobot-houston @sarah11918 @trueberryless