-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugins): add Starlight Ion theme #2620
base: main
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello! Thank you for opening your first PR to Starlight! ✨ Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your first contribution to Starlight, @Ast3risk-ops!
Everything looks good to me!
(The additional four spaces will be formatted by the CI formater)
Thanks for sharing this! I think the reason this hasn’t been included so far is that it isn’t a Starlight plugin, which is what this page is focused on:
It looks very cool, but Ion is a template repository that includes custom components and overrides hardcoded rather than a plugin you install and extend Starlight with. That’s not necessarily a bad thing — it makes Ion’s components very flexible when you copy the template because you can edit them directly in your project. But it does mean we may need to think for a second how best to showcase it. |
My bad, I didn't look into this aspect thoroughly enough. |
I guess one option could be to add https://louisescher.github.io/starlight-ion-theme/ to the Site Showcase instead? At least it would be linked that way. |
It's not a site using starlight though, it's a set of components. |
Description
Added the Starlight Ion theme since it's featured on https://astro.build (themes section > docs) yet for some reason it's not showcased in the Starlight docs.
I did not make this theme.