Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new icons #2760

Merged
Merged

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Jan 7, 2025

Description

As discussed on Discord, this PR adds new icons to the Starlight icon set:

Ran all SVGs through SVGOMG to optimize them.

Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: 9000a2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Jan 7, 2025
Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 97c9cb7
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/677d51162150890008a1f98a
😎 Deploy Preview https://deploy-preview-2760--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect! I checked the deploy preview and the icons display correctly, the names and ordering makes sense, and the SVGOMG compression also looks like it matches our existing similar icons.

Thanks @HiDeoo!

@delucis delucis merged commit aec9edd into withastro:main Jan 7, 2025
15 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants