fix: support escaped newlines within string literals (#293)

withered-magic · Oct 18, 2024 · 3e0f636 · 3e0f636
1 parent e84dec9
commit 3e0f636
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/crates/starpls_lexer/src/lib.rs b/crates/starpls_lexer/src/lib.rs
@@ -810,7 +810,10 @@ impl Cursor<'_> {
                         return (true, triple_quoted);
                     }
                 }
-                '\\' if self.first() == '\\' || self.first() == closing_quote => {
+                '\\' if self.first() == '\\'
+                    || self.first() == closing_quote
+                    || self.first() == '\n' =>
+                {
                     // Bump again to skip the escaped character.
                     self.bump();
                 }

diff --git a/crates/starpls_lexer/src/tests.rs b/crates/starpls_lexer/src/tests.rs
@@ -797,3 +797,20 @@ foo(3 + \
         "#]],
     )
 }
+
+#[test]
+fn test_escaped_newline_in_string() {
+    check_lexing(
+        r#"
+greeting = "Hello, \
+world!""#,
+        expect![[r#"
+            Token { kind: Newline, len: 1 }
+            Token { kind: Ident, len: 8 }
+            Token { kind: Whitespace, len: 1 }
+            Token { kind: Eq, len: 1 }
+            Token { kind: Whitespace, len: 1 }
+            Token { kind: Literal { kind: Str { terminated: true, triple_quoted: false } }, len: 17 }
+        "#]],
+    );
+}