Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toast outlines for persistent toasts #371

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

louisescher
Copy link
Member

Description

  • Improves toasts by adding an outline to persistent toasts, which were barely visible due to not having a colored progress bar.

image

Copy link

changeset-bot bot commented Nov 2, 2024

🦋 Changeset detected

Latest commit: 77ae30a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@studiocms/ui Patch
studiocms Patch
@studiocms/assets Patch
@studiocms/auth Patch
@studiocms/betaresources Patch
@studiocms/core Patch
@studiocms/dashboard Patch
@studiocms/devapps Patch
@studiocms/frontend Patch
@studiocms/imagehandler Patch
@studiocms/renderers Patch
@studiocms/robotstxt Patch
@studiocms/blog Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@studiocms-no-reply
Copy link
Member

Thank you for submitting your Pull Request, the following links will become available for preview shortly:

Copy link

studio-cms-deployments bot commented Nov 2, 2024

The preview deployment failed. 🔴

Open Build Logs

Last updated at: 2024-11-02 12:01:36 CET

Copy link

studio-cms-deployments bot commented Nov 2, 2024

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2024-11-03 10:10:50 CET

Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Copy link
Member

@JusticeMatthew JusticeMatthew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Nice catch too, that's a very common accessibility miss (not using a border for separation when the BG of the two elements doesn't have enough contrast)

@louisescher louisescher self-assigned this Nov 2, 2024
@studiocms-no-reply
Copy link
Member

Thank you for submitting your Pull Request, the following links will become available for preview shortly:

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @louisescher 😁

@Adammatthiesen Adammatthiesen merged commit 79032e9 into issue-0304 Nov 3, 2024
4 checks passed
@Adammatthiesen Adammatthiesen deleted the toast-updates branch November 3, 2024 15:25
@louisescher louisescher restored the toast-updates branch November 10, 2024 12:58
@louisescher louisescher deleted the toast-updates branch November 10, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants