Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(yarn): fix "yarn dev" #293

Closed
wants to merge 1 commit into from
Closed

build(yarn): fix "yarn dev" #293

wants to merge 1 commit into from

Conversation

aesedepece
Copy link
Member

@aesedepece aesedepece commented Aug 2, 2018 •
edited by kronolynx
Loading

  • I have read and understood CODE_OF_CONDUCT document.
  • I have read and understood CONTRIBUTING document.
  • I have read and understood STYLEGUIDE document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • My code is formatted and is accepted by yarn fmt.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

yarn dev was partially broken because of old react/redux devtools.

UPGRADE_EXTENSIONS=1 yarn dev seems to solve the problem as it locally upgrades the react/redux developer extensions.

This commit fixes #291 by adding the UPGRADE_EXTENSIONS=1 flag to the yarn dev task itself.

@aesedepece
build(yarn): fix "yarn dev"
67d6ac5 
`yarn dev` was partially broken because of old react/redux devtools.
`UPGRADE_EXTENSIONS=1 yarn dev` seems to solve the problem as it
locally upgrades the react/redux developer extensions.

This commit fixes witnet#291 by adding the `UPGRADE_EXTENSIONS=1`
flag to the yarn dev task itself
@aesedepece aesedepece requested a review from a team August 2, 2018 14:31
@aesedepece
Copy link
Member Author

FYI: Travis will fail for this PR until a subsequent PR fixing #292 is merged in 😉

@aesedepece
Copy link
Member Author

wtf? Travis didn't fail? @Tommytrg :O

@aesedepece
Copy link
Member Author

Rebased and merged in 560e421

@aesedepece aesedepece closed this Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kronolynx kronolynx kronolynx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build(yarn): "yarn dev" is partially broken
2 participants
@aesedepece @kronolynx