Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed build for Android #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed build for Android #28

wants to merge 1 commit into from

Conversation

eleretic
Copy link

This fixes the build error when trying to use the lib with React Native >=0.54

#25

Fix example taken from getsentry/sentry-react-native#354

@eleretic eleretic mentioned this pull request May 11, 2018
Open
@eleretic eleretic changed the title Fixed build for RN Fixed build for Android May 11, 2018
@daisy1754
Copy link

@guyca @DanielZlotin @doronpr @rotemmiz
If anyone could review this and #14 and then publish new version to npm it'd be very much appreciated.

@lochness42
Copy link

@rotemmiz Would it be possible to get this in and published? Having hacky solutions to this isn't the best. Thanks

@voom-pairing-helionix
Copy link

Are there any plans to move forward with this PR? We encountered this issue as well.

@sarneetk
Copy link

Can this be merged?

@imamrobani
Copy link

same error, how can I fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dewansneha dewansneha dewansneha approved these changes

@talal7860 talal7860 talal7860 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@eleretic @daisy1754 @lochness42 @voom-pairing-helionix @sarneetk @imamrobani @talal7860 @dewansneha