Fix node8 module children bug #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idan-at
force-pushed
the
fix-node8-module-children-bug
branch
from
24cce71
to
c6554dc
Compare
golsan
suggested changes
Dec 3, 2017
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "scoped-require", | |||
| "version": "2.1.2", | |||
| "version": "2.2.0", | |||
There was a problem hiding this comment.
breaking change, please increment the major version
idan-at
force-pushed
the
fix-node8-module-children-bug
branch
from
c6554dc
to
7477439
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix commit only fixes eslint issues (and uses package.json instead of grunt).
It has many differences, but all are syntactic only.
second commit fixes the cyclic require bug (a bug that was fixed in node 8.3.0 regarding module children, see nodejs/node#7131).