Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nissix plugin scope-packages on storybook-snapper #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deanshub
Copy link

@deanshub deanshub commented Mar 8, 2021

Hi, I'm Nissix, the automated PR bot!

Wix is moving its internal packages to the @wix scope (but still in the internal registry). Publishing new unscoped internal packages is no longer allowed, and all existing packages are moving to @wix. This means changing package names, and also all usages of those packages to their @wix scope version.

This PR is an automatic codemod that moves all of your packages to @wix scope, and changes any usages (pacakge.json, imports, requires, etc..) to their @wix version.

‼️ This codemod is best-effort! Meaning it may not have found and fixed all usages, but it did change your package.jsons. So go over the changes carefully and test this version carefully

If you want to know why we don't support publishing unscoped to the internal registry, check out this article on Dependency Confusion

If you are unsure, need help or have questions, reach us at #wix-scope-migration

Error Log:
npx: installed 234 in 7.608s
warning @wix/yoshi > yoshi-flow-legacy > tslint@6.1.3: TSLint has been deprecated in favor of ESLint. Please see palantir/tslint#4534 for more information.
warning @wix/yoshi > yoshi-common > @zeit/webpack-asset-relocator-loader@0.8.0: "@zeit/webpack-asset-relocator-loader" is deprecated in favor of "@vercel/webpack-asset-relocator-loader".
warning @wix/yoshi > yoshi-flow-legacy > yoshi-webpack-utils > @zeit/webpack-asset-relocator-loader@0.8.0: "@zeit/webpack-asset-relocator-loader" is deprecated in favor of "@vercel/webpack-asset-relocator-loader".
warning @wix/yoshi > yoshi-flow-legacy > tslint-config-yoshi > tslint-react@4.2.0: TSLint has been deprecated in favor of ESLint. Please see palantir/tslint-react#210 for more information.
warning " > @storybook/react@5.0.9" has unmet peer dependency "react-dom@".
warning "@storybook/react > @storybook/core@5.0.9" has unmet peer dependency "react-dom@
".
warning "@storybook/react > @storybook/theming@5.0.9" has unmet peer dependency "react-dom@".
warning "@storybook/react > @storybook/core > @storybook/router@5.0.9" has unmet peer dependency "react-dom@
".
warning "@storybook/react > @storybook/core > @storybook/router > @reach/router@1.3.3" has unmet peer dependency "react-dom@15.x || 16.x || 16.4.0-alpha.0911da3".
warning " > babel-loader@8.1.0" has unmet peer dependency "webpack@>=2".
warning " > ts-jest@24.3.0" has unmet peer dependency "jest@>=24 <25".
warning "@wix/yoshi > yoshi-flow-legacy > haste-task-webpack@0.3.3" has incorrect peer dependency "webpack@^3.1.0".
warning "@wix/yoshi > yoshi-flow-legacy > babel-plugin-transform-hmr-runtime@4.286.0" has unmet peer dependency "babel-core@^7.0.0-0".
warning "@wix/yoshi > yoshi-flow-legacy > react-hot-loader@4.13.0" has unmet peer dependency "react-dom@^15.0.0 || ^16.0.0 || ^17.0.0 ".
warning "@wix/yoshi > yoshi-flow-legacy > tslint-plugin-wix-style-react@1.0.9" has incorrect peer dependency "tslint@^5.0.0".
warning "@wix/yoshi > yoshi-flow-legacy > tslint-plugin-wix-style-react@1.0.9" has incorrect peer dependency "typescript@^2.4.0".
warning "@wix/yoshi > yoshi-flow-legacy > tslint-config-yoshi-base@4.167.0" has unmet peer dependency "prettier@^2.0.5".
warning "@wix/yoshi > yoshi-flow-legacy > tslint-config-yoshi-base > tslint-consistent-codestyle@1.16.0" has incorrect peer dependency "tslint@^5.0.0".
warning "@wix/yoshi > yoshi-flow-legacy > tslint-config-yoshi-base > tslint-eslint-rules@5.4.0" has incorrect peer dependency "tslint@^5.0.0".
warning "@wix/yoshi > yoshi-flow-legacy > tslint-config-yoshi-base > tslint-microsoft-contrib@5.2.1" has incorrect peer dependency "tslint@^5.1.0".
warning "@wix/yoshi > yoshi-flow-legacy > tslint-config-yoshi-base > tslint-consistent-codestyle > @fimbul/bifrost@0.21.0" has incorrect peer dependency "tslint@^5.0.0".
warning "@wix/yoshi > yoshi-flow-legacy > yoshi-runtime@1.0.733" has unmet peer dependency "node-sass@^4.11.0".
warning "@wix/yoshi > yoshi-flow-legacy > tslint-config-yoshi > tslint-react@4.2.0" has incorrect peer dependency "tslint@^5.1.0".
warning "@wix/yoshi > yoshi-flow-legacy > tslint-config-yoshi-base > tslint-plugin-prettier@2.3.0" has unmet peer dependency "prettier@^1.9.0 || ^2.0.0".
warning "@wix/yoshi > yoshi-flow-legacy > tslint-config-yoshi-base > tslint-plugin-prettier > eslint-plugin-prettier@2.7.0" has unmet peer dependency "prettier@>= 0.11.0".
warning "@wix/yoshi > yoshi-flow-legacy > yoshi-webpack-utils > mdsvex@0.6.1" has unmet peer dependency "svelte@3.x".

Output Log:
Migrating package "storybook-snapper" in .

Migration from non scope to @wix/scoped packages

/tmp/882ec5cc98719bc98434b7b2d980bf2a

rename package.json dependencies/dev/bundled/peer/optional, jest & eslintConfig

package.json

replace import/require in js/ts files

wallaby.js
.storybook/webpack.config.js

replace node_modules in include & files in json configs

tsconfig.json

yarn install v1.22.5
[1/4] Resolving packages...
[2/4] Fetching packages...
info fsevents@2.1.3: The platform "linux" is incompatible with this module.
info "fsevents@2.1.3" is an optional dependency and failed compatibility check. Excluding it from installation.
info fsevents@1.2.13: The platform "linux" is incompatible with this module.
info "fsevents@1.2.13" is an optional dependency and failed compatibility check. Excluding it from installation.
info fsevents@2.3.2: The platform "linux" is incompatible with this module.
info "fsevents@2.3.2" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Saved lockfile.
Done in 10.22s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant